-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #64
Various fixes #64
Conversation
@lepmik should we merge this, make a new release and install from pip on educloud? |
I would like to put the waveform comparison for unit tracking in here
before making a pip
tor. 4. apr. 2024, 12:35 skrev Alessio Buccino ***@***.***>:
… @lepmik <https://github.com/lepmik> should we merge this, make a new
release and install from pip on educloud?
—
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2CP4DEAPUM24G2I5WHN2TY3UUIVAVCNFSM6AAAAABELJWXDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZWHAYDMOBZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
from pathlib import Path | ||
import datetime | ||
|
||
class TrackMultipleSessions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be super cool to make an additional Tab in the GUI to do this and visualize it
@lepmik last commit sped up imports from ~6s to 2.5s |
Nice!
man. 8. apr. 2024, 15:40 skrev Alessio Buccino ***@***.***>:
… @lepmik <https://github.com/lepmik> last commit sped up imports from ~6s
to 2.5s
—
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2CP4A4I2HU2BTWFHIE4S3Y4KM3FAVCNFSM6AAAAABELJWXDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBSG44TANJYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Agreed
lør. 6. apr. 2024, 12:02 skrev Alessio Buccino ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In src/expipe_plugin_cinpla/tools/trackunitmulticomparison.py
<#64 (comment)>
:
> @@ -0,0 +1,284 @@
+import numpy as np
+import networkx as nx
+import yaml
+from .trackunitcomparison import TrackingSession
+from expipe_plugin_cinpla.data_loader import get_data_path, get_channel_groups, load_spiketrains
+from .track_units_tools import plot_template
+import matplotlib.pylab as plt
+from tqdm import tqdm
+import uuid
+from matplotlib import gridspec
+from collections import defaultdict
+from pathlib import Path
+import datetime
+
+class TrackMultipleSessions:
It would be super cool to make an additional Tab in the GUI to do this and
visualize it
—
Reply to this email directly, view it on GitHub
<#64 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2CP4BA4D4VYL3D34AI6TTY37B27AVCNFSM6AAAAABELJWXDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBUGQ3TGNJVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Fix phy groups
@lepmik could you push the latest changes? |
Automated code formatting
@alejoe91 What is missing for this PR to be merged? |
I think we kept it open to find small bugs etc. If you run black so that linting tests are fixed we can merge! |
Fix #62 and #63
@mariapfj the Kilosort issue needs to be solved on EduCloud. The registration should be fixed by the PR.
For the time being, it's probably good to have
expipe-plugin-cinpla
installed from sources, so we can easily push fixes. Once it's stable, we can make a release and install from pip.I'm meeting with @lepmik tomorrow to set this up.